add async method in Jasmine Tests#4775
Merged
hansl merged 3 commits intoangular:masterfrom Feb 21, 2017
Merged
Conversation
filipesilva
suggested changes
Feb 17, 2017
Contributor
filipesilva
left a comment
filipesilva
left a comment
There was a problem hiding this comment.
Can you also change the usage of .compileComponents in these files?
- https://github.com/angular/angular-cli/blob/master/tests/e2e/tests/build/assets.ts#L89
- https://github.com/angular/angular-cli/blob/master/tests/e2e/tests/test/test-scripts.ts#L34
Please change it to match the changes you already have (add async, chain .compileComponents)
…nts is asynchronous
Contributor
Author
|
@filipesilva done |
filipesilva
approved these changes
Feb 17, 2017
Contributor
filipesilva
left a comment
filipesilva
left a comment
There was a problem hiding this comment.
@wKoza looks good, just waiting for the CI.
Thanks for updating these!
sumitarora
pushed a commit
to sumitarora/angular-cli
that referenced
this pull request
Feb 21, 2017
asnowwolf
pushed a commit
to asnowwolf/angular-cli
that referenced
this pull request
Apr 12, 2017
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add async method if we use compileComponents() because compileComponents is asynchronous
PR #4774